Conversation
ref: jschneier/django-storages#1193 [noissue]
fao89
added a commit
to fao89/pulp_container
that referenced
this pull request
Oct 28, 2022
jschneier/django-storages#1193 Required PR: pulp/pulpcore#3367 [noissue]
fao89
added a commit
to fao89/pulp_container
that referenced
this pull request
Oct 28, 2022
jschneier/django-storages#1193 Required PR: pulp/pulpcore#3367 [noissue]
fao89
added a commit
to fao89/pulp-operator
that referenced
this pull request
Oct 28, 2022
ipanova
approved these changes
Nov 22, 2022
ipanova
left a comment
ipanova
left a comment
Member
There was a problem hiding this comment.
Needs an isssue + changelog entry. Waiting on new django-storages release
ipanova
requested changes
Nov 22, 2022
Member
There was a problem hiding this comment.
sorry, this method needs to be updated get_artifact_url too
and this test pulpcore/tests/functional/api/test_artifact_distribution.py and this file pulpcore/app/settings.py
It also needs docs.
I also expect us adding a separate CI job to test GCP. Will it be a separate PR?
Member
Author
|
I'm waiting django-storages to be released, so I can work on the CI |
Member
|
If you're closing PRs related to the GCP support can you at least file issues and reference this PR. |
Member
Author
|
yes, I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: jschneier/django-storages#1193
No Issue! Just a draft PR to have an idea on what is needed for GCP support